List: Allow selection/highlighting of text in an item [QW] \ Implementation by dmlvr · Pull Request #32840 · DevExpress/DevExtreme

dmlvr · 2026-03-10T08:28:28Z

No description provided.

Copilot

Pull request overview

This PR adjusts dxList swipe wiring to better support use cases like text selection within list items by removing the internal _swipeEnabled switch and only attaching swipe listeners when there is an onItemSwipe subscription. It also updates Scheduler tooltip list options/tests accordingly.

Changes:

Removed the internal _swipeEnabled option from ListBase and stopped passing it from Scheduler tooltip list creation.
Updated ListBase to attach swipe event handlers only when onItemSwipe is subscribed.
Updated affected QUnit tests to reflect the new options shape (and attempted to update a swipe-related List test).

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File	Description
packages/devextreme/testing/tests/DevExpress.ui.widgets/listParts/commonTests.js	Updates a List swipe test (currently inconsistent with actual options/behavior).
packages/devextreme/testing/tests/DevExpress.ui.widgets.scheduler/desktopTooltip.tests.js	Updates assertions for Scheduler tooltip List options after removing `_swipeEnabled`.
packages/devextreme/js/__internal/ui/list/list.base.ts	Removes `_swipeEnabled` and changes swipe listener attachment to depend on action subscription.
packages/devextreme/js/__internal/scheduler/tooltip_strategies/m_tooltip_strategy_base.ts	Stops passing `_swipeEnabled: false` into tooltip List options.

packages/devextreme/js/__internal/ui/list/list.base.ts

packages/devextreme/testing/tests/DevExpress.ui.widgets/listParts/commonTests.js

…lighting_text_of_the_items

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

packages/devextreme/testing/tests/DevExpress.ui.widgets/listParts/commonTests.js

pharret31 · 2026-03-11T13:05:52Z

packages/devextreme/js/__internal/ui/list/list.base.ts

+
+    return result;
+  }
+


are there any tests that checks resubscriptions in existing tests?

we have test which checks onItemSwipe subscription by on method

DevExtreme/packages/devextreme/testing/tests/DevExpress.ui.widgets/listParts/commonTests.js

Line 1164 in f6f41ab

QUnit.test('onItemSwipe - subscription by on method', function(assert) {

packages/devextreme/js/__internal/ui/list/list.base.ts

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

You can also share your feedback on Copilot code review. Take the survey.

packages/devextreme/testing/tests/DevExpress.ui.widgets/listParts/commonTests.js

EugeniyKiyashko · 2026-03-12T18:26:07Z

packages/devextreme/testing/tests/DevExpress.ui.widgets/listParts/commonTests.js

+        pointerMock($item).start().down(0, 0).move(50, 0).up();
+
+        assert.strictEqual(window.getSelection().toString(), textNode.nodeValue.slice(0, 4), 'text selection is preserved after horizontal drag');
+        window.getSelection().removeAllRanges();


You already call removeAllRanges at the module level inside the afterEach hook

removed all extra calls

EugeniyKiyashko · 2026-03-12T18:26:41Z

packages/devextreme/testing/tests/DevExpress.ui.widgets/listParts/commonTests.js

+
+        const { $item, textNode } = getFirstListItemAndTextNode(this.element);
+        assert.ok(!!textNode, 'text node found in list item');
+        if(!textNode) return;


Why we need to return here? I would prefer to remove it

EugeniyKiyashko · 2026-03-12T18:27:17Z

packages/devextreme/testing/tests/DevExpress.ui.widgets/listParts/commonTests.js

+        });
+
+        const { $item, textNode } = getFirstListItemAndTextNode(this.element);
+        assert.ok(!!textNode, 'text node found in list item');


It would be better to use strictEqual() instead

EugeniyKiyashko · 2026-03-12T19:15:04Z

packages/devextreme/js/__internal/ui/list/list.base.ts

+    const result = super.on(eventName, eventHandler);
+
+    const isItemSwipeOn = eventName === 'itemSwipe'
+      || (isPlainObject(eventName) && Object.prototype.hasOwnProperty.call(eventName, 'itemSwipe'));


Suggested change

|| (isPlainObject(eventName) && Object.prototype.hasOwnProperty.call(eventName, 'itemSwipe'));

|| (isPlainObject(eventName) && Object.hasOwn(eventName, 'itemSwipe'));

Is the follow checking enough?

(isPlainObject(eventName) && ('itemSwipe' in eventName));

returned

Object.prototype.hasOwnProperty.call(eventName, 'itemSwipe')

EugeniyKiyashko · 2026-03-12T19:17:31Z

packages/devextreme/js/__internal/ui/list/list.base.ts

+  on(eventName: string | { [key: string]: Function }, eventHandler?: Function): this {
+    const result = super.on(eventName, eventHandler);
+
+    const isItemSwipeOn = eventName === 'itemSwipe'


Suggested change

const isItemSwipeOn = eventName === 'itemSwipe'

const hasItemSwipeHandler = eventName === 'itemSwipe'

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

You can also share your feedback on Copilot code review. Take the survey.

packages/devextreme/testing/tests/DevExpress.ui.widgets/listParts/commonTests.js

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

You can also share your feedback on Copilot code review. Take the survey.

packages/devextreme/js/__internal/ui/list/list.base.ts

implementattion

b019702

dmlvr self-assigned this Mar 10, 2026

dmlvr added the 26_1 label Mar 10, 2026

dmlvr requested a review from a team as a code owner March 10, 2026 08:28

Copilot AI review requested due to automatic review settings March 10, 2026 08:28

dmlvr requested a review from a team as a code owner March 10, 2026 08:28

Copilot started reviewing on behalf of dmlvr March 10, 2026 08:29 View session

Copilot AI reviewed Mar 10, 2026

View reviewed changes

dmlvr added 3 commits March 10, 2026 12:45

Merge remote-tracking branch 'upstream/26_1' into 26_1_3648_list_high…

f1ae953

…lighting_text_of_the_items

revrite tests and code optimization

f6f41ab

fix on\off subscribtion

2b2c1d6

Copilot AI review requested due to automatic review settings March 10, 2026 13:50

Copilot started reviewing on behalf of dmlvr March 10, 2026 13:51 View session

Copilot AI reviewed Mar 10, 2026

View reviewed changes

packages/devextreme/testing/tests/DevExpress.ui.widgets/listParts/commonTests.js Outdated Show resolved Hide resolved

pharret31 reviewed Mar 11, 2026

View reviewed changes

add Highlighting tests

f547ea3

EugeniyKiyashko reviewed Mar 12, 2026

View reviewed changes

packages/devextreme/js/__internal/ui/list/list.base.ts Outdated Show resolved Hide resolved

dmlvr added 2 commits March 12, 2026 18:18

update list.base and add tests for new behavior

b029181

some tests optimization

5434c61

Copilot AI review requested due to automatic review settings March 12, 2026 16:34

Copilot started reviewing on behalf of dmlvr March 12, 2026 16:35 View session

Copilot AI reviewed Mar 12, 2026

View reviewed changes

packages/devextreme/testing/tests/DevExpress.ui.widgets/listParts/commonTests.js Outdated Show resolved Hide resolved

EugeniyKiyashko reviewed Mar 12, 2026

View reviewed changes

fix after review

2f7a9a5

dmlvr force-pushed the 26_1_3648_list_highlighting_text_of_the_items branch from 0b422d2 to 2f7a9a5 Compare March 13, 2026 08:42

Copilot AI review requested due to automatic review settings March 13, 2026 08:42

Copilot started reviewing on behalf of dmlvr March 13, 2026 08:43 View session

Copilot AI reviewed Mar 13, 2026

View reviewed changes

packages/devextreme/testing/tests/DevExpress.ui.widgets/listParts/commonTests.js Outdated Show resolved Hide resolved

dmlvr added 2 commits March 13, 2026 10:52

remove double of onItemSwipe test

71aaf77

small test fix

0c843c8

Copilot AI review requested due to automatic review settings March 13, 2026 08:55

Copilot started reviewing on behalf of dmlvr March 13, 2026 08:56 View session

Copilot AI reviewed Mar 13, 2026

View reviewed changes

packages/devextreme/js/__internal/ui/list/list.base.ts Show resolved Hide resolved

EugeniyKiyashko approved these changes Mar 13, 2026

View reviewed changes

Tucchhaa approved these changes Mar 13, 2026

View reviewed changes

dmlvr merged commit edb1a98 into DevExpress:26_1 Mar 13, 2026
130 of 131 checks passed

	\|\| (isPlainObject(eventName) && Object.prototype.hasOwnProperty.call(eventName, 'itemSwipe'));
	\|\| (isPlainObject(eventName) && Object.hasOwn(eventName, 'itemSwipe'));

	const isItemSwipeOn = eventName === 'itemSwipe'
	const hasItemSwipeHandler = eventName === 'itemSwipe'

Conversation

dmlvr commented Mar 10, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

pharret31 Mar 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

EugeniyKiyashko Mar 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dmlvr Mar 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

pharret31 Mar 11, 2026 •

edited

Loading

EugeniyKiyashko Mar 12, 2026 •

edited

Loading

dmlvr Mar 13, 2026 •

edited

Loading